Implementation Notes

Summary

Implementing issue #68 through delivery-phase -> implement-spec in parallel mode.

Execution Mode

parallel

Execution Board

Status	Tasks
Completed	T1, T2, T3, T4, T5
In progress
Unblocked next
Blocked
Current wave

Deviations From the Plan

T4 was narrowed to docs/notes only. GitHub/tracker closeout waits until after mandatory review.
T4 dependency was corrected from [T3, T5] to [T3]; T5 still depends on T4.
Accepted P2 review finding fixed the test harness only: the generated-config proof remains at runScaffold, but the temp fixture now links dependencies from repo node_modules instead of calling bun install.
Boundary/deferred P2 review finding leaves existing root/wiki TypeScript/Oxlint lockfile churn untouched; issue #68 only adds apps/cli dependency ownership on top of that dirty state.

Surprises and Decisions

Registry metadata showed newer oxlint and ultracite releases, but readonly research confirmed the reported type failure does not require a version bump.
The worktree already had package/lock/docs changes before implementation; this run preserves those and only layers required issue #68 edits.
bun.lock includes pre-existing root/wiki dependency churn corresponding to dirty root package.json and apps/wiki/package.json changes. Do not revert or normalize it in issue #68 closeout.

Sanity Checks

Check	Result	Notes
`/Users/stefan/.bun/bin/bun run --cwd apps/cli test -- --testNamePattern "typecheckable Effect Oxlint config"`	Passed	1 passed, 197 skipped.
`/Users/stefan/.bun/bin/bun run --cwd apps/cli test -- --testNamePattern "typecheckable Effect Oxlint config"`	Passed	Hermetic follow-up: 1 passed, 198 skipped; no temp `bun install`.
`/Users/stefan/.bun/bin/bun run --cwd apps/cli test -- --testNamePattern "Oxlint config"`	Passed	3 passed, 195 skipped.
`/Users/stefan/.bun/bin/bun run --cwd apps/cli test -- --testNamePattern "Oxlint config"`	Passed	Hermetic follow-up: 3 passed, 196 skipped.
`/Users/stefan/.bun/bin/bun run --cwd apps/cli check-types`	Passed	Worker validation.
`/Users/stefan/.bun/bin/bun run --cwd apps/cli check-types`	Passed	Hermetic follow-up validation.
`/Users/stefan/.bun/bin/bun run check-types --filter=@punks/cli`	Passed	Turbo ran `@punks/scaffold`, `@punks/contract`, and `@punks/cli` check-types.
`/Users/stefan/.bun/bin/bun run --cwd apps/cli test -- src/scaffold/run.test.ts`	Passed	15 tests passed.
`git diff --check -- apps/cli/src/scaffold/output.ts apps/cli/src/scaffold/run.test.ts apps/cli/package.json apps/wiki/content/docs/project/specs/cli/issue-68-effect-oxlint-rule-typing/PLAN.md apps/wiki/content/docs/project/specs/cli/issue-68-effect-oxlint-rule-typing/IMPLEMENTATION-NOTES.md`	Passed	No whitespace errors.
`git diff --check -- .agents/notes/2026-07-09-cli-check-ultracite-dependency.md apps/wiki/content/docs/project/specs/cli/issue-68-effect-oxlint-rule-typing/PLAN.md apps/wiki/content/docs/project/specs/cli/issue-68-effect-oxlint-rule-typing/IMPLEMENTATION-NOTES.md`	Passed	Exited 0 with no output. Plain `git diff` does not inspect the two untracked spec files.
`git diff --check --no-index -- /dev/null apps/wiki/content/docs/project/specs/cli/issue-68-effect-oxlint-rule-typing/PLAN.md`	No whitespace diagnostics	Exit 1 is expected for no-index diff against `/dev/null`.
`git diff --check --no-index -- /dev/null apps/wiki/content/docs/project/specs/cli/issue-68-effect-oxlint-rule-typing/IMPLEMENTATION-NOTES.md`	No whitespace diagnostics	Exit 1 is expected for no-index diff against `/dev/null`.

UI Evidence Links

No UI evidence required; this delivery changes CLI scaffold generation, package metadata, and docs/spec artifacts only.

Acceptance Criteria Status

Criterion	Status	Notes
Generated Effect package/app `oxlint.config.ts` files typecheck under workspace `tsc` checks when `effect-js/no-import-from-barrel-package` is included.	Met	New `runScaffold` regression runs `tsc` against the generated package config.
The generated rule value uses an Oxlint-compatible typed shape.	Met	Generator emits `localRules satisfies OxlintConfig["rules"]`, preserving the tuple shape.
`hi scaffold setup --yes` still writes or patches nearest package/app Oxlint configs.	Met	Existing create/merge Oxlint config tests plus the new Effect fixture pass.
Missing lint dependencies needed by generated nested config remain declared on owning `package.json`.	Met	Generated fixture uses catalog deps; `apps/cli` now owns local config deps.
A focused regression test fails pre-fix and passes after the fix.	Met	RED captured TS2345; GREEN command passed.
If current package versions are part of the failure, owning package versions are updated without weakening nested-config behavior.	Met	No version bump required; T2 added missing ownership deps using current repo policy versions.

Manual Review Checklist

Area	Check	How to perform	Expected result
CLI scaffold	Regenerate an Effect workspace lint config	Run the focused scaffold test from `PLAN.md` or run `hi scaffold setup --yes` in an Effect workspace fixture.	Nested `oxlint.config.ts` imports Oxlint types, preserves Effect rule options, and typechecks.

Pre-existing Issues

Multiple package/docs files were dirty before issue #68 implementation began; this run does not own or revert those changes.
Existing root/wiki TypeScript/Oxlint dependency churn in bun.lock is boundary/deferred. The issue #68 dependency change is limited to apps/cli owning its local Oxlint config dependencies.

Remaining Work

Complete tracker/GitHub closeout after final operator review.

Implementation Notes

On this page