Harness Phase Upgrades Implementation Notes
Harness Phase Upgrades Implementation Notes
Summary
- Hardened shared phase contracts around auditable TDD evidence.
- Integrated the learning loop into
docs-ingest-phaseinstead of creating strategy, ideation, pulse, ordocs/solutions/branches. - Pushed shared skill source as
wearedevpunks/skills@ea114f8, synced that public commit intoapps/cli/skills, and aligned affected active.agents/skillsdirs from the CLI bundle. - Added a scaffolded root prompt invariant and a focused content test proving it.
Execution Mode
sequential
Deviations From the Plan
implement-specsequential mode normally uses one implementation worker. The available subagent tool explicitly allows spawning only when the user asks for subagents, so implementation stayed in the parent thread.bun run sync:skillssyncs the CLI distributed bundle underapps/cli/skills; it does not update this checkout's active.agents/skillsmirror. The affected.agentsskill dirs were manually aligned from the synced bundle.- The first RED command attempt failed on missing local dependencies before reaching the assertion. After
bun install, the RED run failed on the expected prompt invariant.
Progress
| Task | Status | Notes |
|---|---|---|
| T1 | Complete | tdd now states no production code before RED, defines applicability, escape hatches, and recovery. |
| T2 | Complete | create-plan schema now carries TDD status, commands, evidence, and non-testable reasons. |
| T3 | Complete | implement-spec and review-phase now block or fail missing RED/GREEN proof for behavior-changing work. |
| T4 | Complete | docs-ingest-phase now owns scoped learning artifacts and refresh outcomes. |
| T5 | Complete | Scaffolded root prompt invariant was added with RED/GREEN test evidence. |
| T6 | Complete | Root docs, runbook, wiki log, spec, and notes were updated. |
Sanity Checks
| Check | Result | Notes |
|---|---|---|
git diff --check in /Users/stefan/Desktop/repos/wearedevpunks-skills | Passed | Shared-source diff had no whitespace errors before commit. |
bun run --cwd apps/cli test src/content/content.test.ts before prompt patch | Failed as expected | After dependency install, failure was the missing routed-learning prompt invariant. |
bun run --cwd apps/cli test src/content/content.test.ts after prompt patch | Passed | 1 file, 18 tests passed. |
bun run sync:skills | Passed | Pulled wearedevpunks/skills@ea114f8 into apps/cli/skills. |
diff -qr /Users/stefan/Desktop/repos/wearedevpunks-skills/skills apps/cli/skills | Passed | CLI distributed skill bundle matches upstream source. |
Affected .agents/skills directory diffs against apps/cli/skills | Passed | Active local mirror matches the synced bundle for changed skills. |
Acceptance Criteria Status
| Criterion | Status | Notes |
| ---------------------------------------------------------------- | ------ | ------------------------------------------------------------------------------------------------ | ----------------------------------------------------------- |
| tdd declares the hard law for behavior-changing work. | Met | Shared and synced tdd skill include no-production-code-before-RED language. |
| tdd documents code-before-RED recovery. | Met | Recovery requires a public-result RED test, GREEN patch, and tdd_status: recovered. |
| create-plan requires task-level TDD evidence fields. | Met | Plan schema and TDD reference list all required fields. |
| implement-spec blocks task completion without proof or reason. | Met | Lifecycle and sequential refs treat evidence as completion contract. |
| review-phase blocks missing proof. | Met | Review workflow calls missing RED/GREEN proof a blocking finding. |
| docs-ingest-phase owns the learning loop. | Met | New learning-artifacts reference defines capture, dedupe, refresh, and retirement outcomes. |
| Learning artifacts distinguish bug and knowledge tracks. | Met | learning_type: bug | knowledge plus shared and type-specific fields documented. |
| Future phases scan prior learnings. | Met | Requirements, grill, spec, plan, debugging, and review skills now include routed-learning scans. |
| Scaffolded root prompt carries compact invariant. | Met | rootPromptTemplate includes the invariant and focused content test covers it. |
| Docs/runbooks explain updated contracts. | Met | docs/README.md and docs/runbooks/dp-cli-scaffolding.md updated. |
Manual Review Checklist
| Area | Check | How to perform | Expected result |
|---|---|---|---|
| Shared TDD contract | Verify hard-law language. | Read /Users/stefan/Desktop/repos/wearedevpunks-skills/skills/agnostic/quality/tdd/SKILL.md. | Skill requires RED before production code and documents recovery. |
| Distributed skill bundle | Verify synced output. | Read apps/cli/skills/agnostic/planning/create-plan/references/plan-schema.md and apps/cli/skills/phases/docs-ingest-phase/references/learning-artifacts.md. | Bundle contains TDD evidence fields and learning refresh outcomes. |
| Active skill mirror | Verify local active skills. | Compare affected .agents/skills/* dirs against their apps/cli/skills/* sources. | Active mirror matches the synced bundle. |
| Root prompt invariant | Verify scaffold guidance. | Run bun run --cwd apps/cli test src/content/content.test.ts. | Content test passes and root prompt includes the routed-learning sentence. |
| Operator docs | Verify human-facing docs. | Read docs/runbooks/dp-cli-scaffolding.md. | Runbook describes RED/GREEN evidence and docs-ingest learning refresh. |
Remaining Work
None.