SpecsCLIDesign Phase Asset Evidence
Design Phase Asset Evidence Implementation Notes
Implementation Notes
Summary
- Implemented repo settings authority, repo asset management, route-gated
design-phase, visual evidence handoff guidance, scaffold/update provider checks, and synced packaged skills for IP-273/IP-277, IP-274/IP-282, IP-275/IP-287, and IP-276/IP-292/IP-294.
Execution Mode
- parallel
Deviations From the Plan
- None yet.
Surprises and Decisions
wearedevpunks-skillshad pre-existing dirty changes in frontend taste/imagegen paths before this run. This delivery will not revert or reshape those files.- Plan review found unsafe T1/T6 and T7/T8 parallelism plus weak validation gates. The plan was patched before continuing beyond Wave 1.
- Source skill changes were committed and pushed in
/Users/stefan/Desktop/repos/wearedevpunks-skillsas6b609de feat: add design phase asset evidence skills. bun run sync:skillsupdated packaged Harness skills. Active.agents/skillsupdate was previewed but not applied becausedp update --baseline bundled --checkreported 106 managed changes from baseline drift/local-edited generated agent files. The preview confirms the new skills would be emitted.
Sanity Checks
| Check | Result | Notes |
|---|---|---|
| Worker guard | Passed | .codex/config.toml has [agents], global config has [agents], .agents/subagents/manifest.mjs exists. |
| Targeted CLI tests | Passed | bun --cwd apps/cli test -- src/scaffold/stage.test.ts src/core/tools.test.ts src/update/run.test.ts: 3 files, 53 tests. |
| CLI check | Passed | bun run check --filter=@punks/cli. |
| Wiki check | Passed | bun run check --filter=@punks/wiki. |
| Repo check | Passed | bun run check:repo. |
UI Evidence Links
| Surface | Viewport | Before | After | Notes |
|---|---|---|---|---|
| Not applicable | Not applicable | Not applicable | Not applicable | This delivery changes CLI/docs/skills, not rendered UI. |
Acceptance Criteria Status
| Criterion | Status | Notes |
|---|---|---|
| Design-phase route-gated skill | Done | Source skill and packaged skill synced; router plus intake, grill, prototype, approval, backlog, and delivery-handoff phases created. |
| Repo settings provider authority | Done | .devpunks/settings.json is read/written by scaffold/update and takes precedence over legacy wiki hints. |
| Repo asset management skill | Done | Concise skill added with provider refs for GitHub, GitLab, Azure, and Bitbucket. |
| Visual evidence backlog and PR handoff | Done | design-phase, write-backlog, implement-spec, and delivery-phase now route durable assets through repo-asset-management. |
Manual Review Checklist
- Settings authority: run
bun --cwd apps/cli test -- src/scaffold/stage.test.ts src/core/tools.test.ts src/update/run.test.ts; settings precedence, backfill, prompt persistence, Bitbucket no-CLI behavior, ambiguous hint failures, and required-tool checks pass. - Skill distribution: verify
apps/cli/skills/phases/design-phase/SKILL.md,apps/cli/skills/agnostic/repo-asset-management/SKILL.md, catalog entries, pack entries, andapps/cli/.devpunks-cache/skills-sync.json; new skills are packaged and cataloged. - Visual evidence handoff: search
repo-asset-management,approved artifact,before/after, andUI Evidencein packagedwrite-backlog,implement-spec, anddelivery-phase; backlog and PR evidence guidance references the shared repo asset skill. - Repo validation: run
bun --cwd apps/cli test -- src/scaffold/stage.test.ts src/core/tools.test.ts src/update/run.test.ts && bun run check --filter=@punks/cli && bun run check --filter=@punks/wiki && bun run check:repo; all checks pass.
Pre-existing Issues
- Shared skill repo had unrelated dirty frontend skill changes before this delivery.
- Active
.agents/skillsmirror was not regenerated because previewed scaffold update would also rewrite 100+ unrelated managed harness files due existing baseline drift/local edits. Packaged skills and catalog are updated; consumer mirrors will receive them on a safe scaffold/update run.
Out of Scope Observations
- None yet.
Remaining Work
- None.
Review
- Initial review found two P2 issues: Bitbucket used a made-up generic
bbCLI requirement, and legacy wiki provider backfill guessed when hints conflicted. - Fixes: Bitbucket contributes no repository CLI requirement; legacy provider hint conflicts now raise
CliValidationError. - Targeted re-review result: no findings.
Tracker Closeout
- Linear comments posted with evidence for IP-273, IP-274, IP-275, IP-276, IP-277, IP-282, IP-287, IP-292, and IP-294.
- All nine issues were moved to
Done.
Docs Ingest
- Selected path: private/internal.
- Inputs processed: routed spec folder, implementation notes, wiki provider note, root docs, and scaffold runbook.
- Docs written:
docs/README.md,docs/runbooks/dp-cli-scaffolding.md,apps/wiki/backlog-provider.md,apps/wiki/content/docs/project/backlog-provider.mdx, and routed spec artifacts. - Routed metadata:
backlog-providerwas removed from project navigation;IP-273-design-phase-asset-evidencewas added under CLI specs. - Flow/concept pages: skipped because the routed spec, plan, and implementation notes are the canonical internal artifact for this delivery.
- Public docs: no-op; no reader-facing product docs were requested or materially changed.
- Validation:
bun run check --filter=@punks/wikiandbun run check:repopassed.
Steering
| Date | Feedback | Changes |
|---|---|---|
| 2026-06-25 | User requested full parallel delivery and concise skill edits with writing-great-skills. | Created spec, plan, and parallel execution notes. |
| 2026-06-25 | Plan reviewer flagged wave ordering and validation blockers. | Patched PLAN.md: T6 waits for T1, T8 waits for T7, T1 includes update tests, static skill checks include acceptance mapping. |
| 2026-06-25 | Code review found Bitbucket CLI overreach and ambiguous legacy provider backfill. | Fixed Bitbucket mandatory tools to [], surfaced conflicting legacy hints as CliValidationError, and added regression tests. |